Skip to content

feat: Add Dataset pipelines (experimental)#1933

Merged
Luca Forstner (lforst) merged 15 commits into
mainfrom
dataset-pipeline
May 27, 2026
Merged

feat: Add Dataset pipelines (experimental)#1933
Luca Forstner (lforst) merged 15 commits into
mainfrom
dataset-pipeline

Conversation

@ankrgyl
Copy link
Copy Markdown
Contributor

@ankrgyl Ankur Goyal (ankrgyl) commented May 3, 2026

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If this PR is still relevant, please leave a comment, push an update, or remove the stale label. Thank you for your contributions!

@github-actions github-actions Bot added the stale label May 18, 2026
@github-actions github-actions Bot removed the stale label May 20, 2026
@lforst Luca Forstner (lforst) self-requested a review May 22, 2026 08:18
Comment thread js/src/dataset-pipeline.ts Outdated
Comment on lines +79 to +81
export function getRegisteredDatasetPipelines(): DatasetPipelineDefinition[] {
return [...registry()];
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have this? I think we can remove it, plus it's associated functionality.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use this so that you don't have to export each dataset pipeline. it's an analogous thing to how we extract Eval body definitions

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the exact use-case? I think I kinda get it but it honestly doesn't feel very JSy

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh i see. This is used for bt. Honestly, to avoid API creep (and reduce confusion for SDK users/agents), I would probably just have the global registry and just have bt read off it.

Comment thread js/src/trace.ts
@lforst
Copy link
Copy Markdown
Member

Gonna take this over making sure that it's clear to consumers that this is experimental/beta for now.

@lforst Luca Forstner (lforst) changed the title Dataset pipelines feat: Add Dataset pipelines (beta) May 26, 2026
@lforst Luca Forstner (lforst) changed the title feat: Add Dataset pipelines (beta) feat: Add Dataset pipelines (experimental) May 26, 2026
@ankrgyl
Copy link
Copy Markdown
Contributor Author

Gonna take this over making sure that it's clear to consumers that this is experimental/beta for now.

Oh great. I landed the python change before seeing this. Do you mind marking it as such in python too, and then whenever you are comfortable, we can land this change as well?

@lforst Luca Forstner (lforst) merged commit d69c3ab into main May 27, 2026
41 of 42 checks passed
@lforst Luca Forstner (lforst) deleted the dataset-pipeline branch May 27, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants